fix(ci): deploy electron update metadata to dl.devsy.sh via Netlify#334
Merged
Conversation
Adds `permissions: contents: read` for least-privilege security.
✅ Deploy Preview for devsydev canceled.
|
|
Caution Review failedAn error occurred during the review process. Please try again later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skevetter
enabled auto-merge (squash)
May 18, 2026 14:01
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy-update-metadatajob torelease.ymlthat downloads the three electron updater metadata artifacts (update-metadata-ubuntu-22.04,update-metadata-macos-latest,update-metadata-windows-2022) and deploys them to the dedicated dl.devsy.sh Netlify sitepublish-dir/desktop/so they are served athttps://dl.devsy.sh/desktop/latest*.yml, matching thegenericprovider URL configured indesktop/electron-builder.ymlNETLIFY_DL_SITE_IDsecret (separate from the main site'sNETLIFY_SITE_ID) to avoid touching devsy.shprereleasejob now depends ondeploy-update-metadatato ensure metadata is live before the release is publishedpermissions: contents: read(least-privilege)Required secret:
NETLIFY_DL_SITE_IDmust be added to repo secrets pointing to the dl.devsy.sh Netlify site.